Add migration docs for 02-client refactor #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catShaark
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
seantking,
charleenfei and
damiannolan
as code owners
…ht client impl to migration doc
catShaark
force-pushed
the
add-migration-docs-for-client-refactor
branch
from
13dad85 to
1fc561e
Compare
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
|
Thank you so much for reviewing this. @colin-axner. I'll apply the changes needed |
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
catShaark
force-pushed
the
add-migration-docs-for-client-refactor
branch
from
fad2d0f to
6c9551f
Compare
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
|
Thanks for reviewing this, @crodriguezvega |
catShaark
changed the title
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
seantking
reviewed
Apr 26, 2022
Co-authored-by: Sean King <seantking@users.noreply.github.com>
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
colin-axner
approved these changes
May 9, 2022
3 tasks
oshorefueled
pushed a commit
to ComposableFi/ibc-go
that referenced
this pull request
Aug 9, 2022
* add changes on : ClientState, Header, Misbehaviour, ConsensState, light client impl to migration doc * Update docs/migrations/v3-to-v4.md Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Update docs/migrations/v3-to-v4.md Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Update docs/migrations/v3-to-v4.md Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Update docs/migrations/v3-to-v4.md Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Update docs/migrations/v3-to-v4.md Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * Update docs/migrations/v3-to-v4.md Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * add more entries and more description * Update docs/migrations/v3-to-v4.md Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * Update docs/migrations/v3-to-v4.md Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * Update docs/migrations/v3-to-v4.md Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * Update docs/migrations/v3-to-v4.md Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * Update docs/migrations/v3-to-v4.md Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * Update docs/migrations/v3-to-v4.md Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * Update docs/migrations/v3-to-v4.md Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * Update docs/migrations/v3-to-v4.md Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * Update docs/migrations/v3-to-v4.md Co-authored-by: Sean King <seantking@users.noreply.github.com> * Update docs/migrations/v3-to-v4.md Co-authored-by: Carlos Rodriguez <carlos@interchain.io> * update migration doc * update migration doc * update migration doc Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io> Co-authored-by: Sean King <seantking@users.noreply.github.com>
CosmosCar
pushed a commit
to caelus-labs/ibc-go
that referenced
this pull request
Nov 6, 2023
Fixes cosmos#1283 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit Refactor: - Improvement: Enhanced the transaction handling process in the `TxMempool` module. Transactions are now more accurately filtered based on their gas and data size limits, ensuring that only valid transactions are processed. This update improves the overall efficiency and reliability of transaction processing. Tests: - Test: Added a new test, `TestTxMempoolTxLargerThanMaxBytes`, to verify the correct handling of large transactions. This ensures the robustness of the system when dealing with transactions of varying sizes. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Ganesha Upadhyaya <gupadhyaya@Ganeshas-MacBook-Pro-2.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ht client impl to migration doc
Description
I add migration docs for 02-client refactor, this should clearly explain how to go from the old 02-client API to the new API
closes: #1202
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes